Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force allowlisted URLs into Google Container #135

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aaronkollasch
Copy link

@aaronkollasch aaronkollasch commented May 23, 2022

This PR is to propose a fix for #133.

There are some SSO domains that I also use in a different container – I want the allowlist to allow those domains to be accessed from the Google Container, but not switch containers if the domains are accessed elsewhere. I don't want to use the "don't override containers" option as I find overriding Google domains from other containers still useful.

My current workaround is to add the SSO domains to the allowlist whenever Google requires SSO auth, log in on the Google Container using the SSO domains, then remove them from the list. This is annoying as it occurs ~weekly.

I'm proposing two possible fixes:

  1. Simply don't force allowlisted URLs to be opened in the Google Container.
  2. Add a separate "soft allowlist" for such URLs. (Though the "soft allowlist" is more in line with my expectations for an allowlist than the current "allowlist", which mandates inclusion).

The two commits on this branch correspond to these two options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant